add the no-strip flag to the clip command
#9216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansi strip removes tab symbols, which is sometimes useful (for example, when using the `... | to tsv | clip` command). Therefore, I added a flag to prevent using `ansi strip` in the clip command.
fdncred
reviewed
May 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9216 +/- ##
==========================================
- Coverage 68.92% 68.54% -0.38%
==========================================
Files 635 636 +1
Lines 102041 102281 +240
==========================================
- Hits 70329 70106 -223
- Misses 31712 32175 +463 |
amtoine
requested changes
May 17, 2023
|
so this is ready for review, isn't it @maxim-uvarov ? 😋 |
amtoine
added
the
std-library
|
@amtoine, yep, it is ready for review! 🙏 |
amtoine
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ansi strip(used in the clip command by default) removes tab symbols, which is sometimes not useful (for example, when using the[[a b]; [1 2]] | to tsv | clipcommand). Therefore, I added a flag to prevent usingansi stripin the clip command.User-Facing Changes
Tests + Formatting
After Submitting