Added assert not command (assertion that the value/expression is false)
#9235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skelly37
changed the title
assert not command with its testassert not command (assertion that the value/expression is false)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9235 +/- ##
=======================================
Coverage 68.53% 68.53%
=======================================
Files 636 636
Lines 102281 102281
=======================================
Hits 70099 70099
Misses 32182 32182 |
amtoine
added
the
std-library
amtoine
requested changes
May 19, 2023
|
it's all green, so let's land this 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new command to simplify assertions for
false.The name is just a draft, though I could not come up with a better name. I have rejected
assert false, because I would have to renameasserttoassert truewhich would break the compatibility and worsen the shell experience of the good oldassert.Another idea I have rejected was something like
assert_falseto keep it consistent with the naming convention of our stdlib.I am open to suggestions :)
User-Facing Changes
Just a new command
Tests + Formatting
After Submitting