Allow duration defaults

[MariaSolOs]

Description

Fixes #9217 (some cases, still can't accept all default expressions)

User-Facing Changes

• Follow-up of Change type of parameter default values to Option<Value> #8940, expanding eval_constant so that it can also evaluate values with units.

Tests + Formatting

• A unit test was added to verify that defaults like 1sec are accepted.

[MariaSolOs]

Ehhh should I be concerned about the failed coverage check? 😅

[fdncred]

oh, wow. that's a nice fix! thanks so much.

no, don't worry about the coverage failing. i restarted it to see if it would finish.

this seems to work great with any durations and filesizes. I'm totally down for incremental fixes because it's one step forward.

i did notice, unrelated to this pr, that it's kind of weird how our file sizes reduce. 1mb says 1000.0kb, 1kb says 1,000 b, etc. i mean, i guess it's right, but it's kind of weird.

❯ def f2 [ g = 1mb ] {echo $g}
❯ f2
1000.0 KB
❯ f2 1kb
1,000 B
❯ f2 1b
1 B
❯ f2 1_000_000b
1000.0 KB
❯ 1_000_000b
1000.0 KB
❯ 1mb
1000.0 KB

[amtoine]

thanks maria 😊

[MariaSolOs]

Always happy to help!

[1Kinoti]

i did notice, unrelated to this pr, that it's kind of weird how our file sizes reduce. 1mb says 1000.0kb, 1kb says 1,000 b, etc. i mean, i guess it's right, but it's kind of weird.

@fdncred this conversion is the one responsible for this reduction. the conversion values come from the third part of this tuple.

[fdncred]

@1Kinoti has it always reduced this way, i can't remember?

[1Kinoti]

i just copied it over in #9190, so yes