Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to have a list of glob excludes #9343

Merged
merged 1 commit into from Jun 2, 2023

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Jun 2, 2023

Description

This change allows you to have a list of exclude globs such as:

glob **/* --not [**/target/** **/.git/**]

TODO: Allow the input glob to be multiples too with wax::any(patterns)?

The breaking change part is that the excludes have to be supplied as a list, between [ and ].

User-Facing Changes

Tests + Formatting

After Submitting

@fdncred fdncred added the pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes label Jun 2, 2023
@fdncred fdncred merged commit 5c57d6a into nushell:main Jun 2, 2023
16 checks passed
@fdncred fdncred deleted the glob_not_lists branch June 2, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant