Fix config creation during printing #9353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 7f758d3 and re-implements it.
This fixes #9264 without cloning the engine state and using
merge_env()
by using both the config in permanent state and runtime stack.Previous solution #9304 required cloning engine state for every print which can get substantial if you have a lot/large values stored in the engine. Also,
merge_env()
is intended to be used only at the separation between eval and parsing. I hope this approach is cleaner.This works now
User-Facing Changes
Tests + Formatting
After Submitting