Enable history entry exclusion with leading space #9371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes use of the feature introduced by nushell/reedline#566 Follows precedent found in bash/zsh/fish to exclude lines starting with a space from the history. Like in fish you can still recall the last entry once but it will not be stored and will be forgotten after the next submitted entry. If we consider this to be problematic we can decide to add a config point for this behavior, but at first I was a bit hesistant expanding the config in this area.
|
are we ready to land this? |
|
@sholderbach |
|
My preference for good defaults over too much config is expressed in this (as it adds it without a config point.) If there are good reasons not to do it, I can add a config point. Else I would vote for landing it and if there is a significant pushback we can follow this up with a config. (The bash options are mentioned in #9387, but if I read it correctly the main interest is in having the feature?) |
|
i'm fine with landing it without a config point. let's see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes use of the feature introduced by nushell/reedline#566
If we consider this to be problematic we can decide to add a config
point for this behavior, but at first I was a bit hesistant expanding
the config in this area.
User-Facing Changes
Follows precedent found in bash/zsh/fish to exclude lines starting with
a space from the history.
Like in fish you can still recall the last entry once but it will not be
stored and will be forgotten after the next submitted entry.
Tests + Formatting
(-)