Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable bracketed paste during evaluation #9399

Merged
merged 1 commit into from Jun 10, 2023

Conversation

WindSoilder
Copy link
Collaborator

@WindSoilder WindSoilder commented Jun 10, 2023

Description

Fixes: #9218

When user execute some commands involve user input, currently if we enable bracketed_paste, it will results strange behavior (Pasting 0~ and 1~ around texts, e.g: aaa -> 0~aaa1~) And this is why gpg with paste failed.

Sorry that it's hard to make relative testing...

User-Facing Changes

Tests + Formatting

After Submitting

@fdncred fdncred merged commit 6e638ab into nushell:main Jun 10, 2023
16 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Jun 10, 2023

Thanks. Hopefully this will help people. I don't really like the "use if not windows" since it breaks cross-platform compliance stuff but it's probably necessary for now.

@sholderbach
Copy link
Member

Thanks for investigating this @WindSoilder. If this works out we should probably move that whole functionality into reedline's read_line() so it leaves the bracketed paste mode when returning, to have a clean boundary for responsibility.

@fdncred
Copy link
Collaborator

fdncred commented Jun 10, 2023

good point stefan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting into Terminal entirely broken since 0.80.0 (Example: GPG Passphrase Paste)
3 participants