Remove ZB and ZiB from file size type #9427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2023 03:31
This PR removes ZB and ZiB from file size type, as they were showing incorrect values due to an integer overflow.
sholderbach
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Thank you very much for the thorough first PR! Well spotted that the default_config.nu also needed an update.
I think removing the rather hypothetical ZB/ZiB makes both practical sense and also doesn't force us to incur a deeper modification of Value. I would vote for this PR as the solution to #9337.
Will mark this as a breaking change so we include it with the release notes (nushell/nushell.github.io#945)
sholderbach
added
the
pr:breaking-change
|
agreed, thanks |
ghost
mentioned this pull request
ghost
deleted the
kit494way
added a commit
to kit494way/tree-sitter-nu
that referenced
this pull request
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes ZB and ZiB from file size type, as they
were showing incorrect values due to an integer overflow.
Fixes: #9337
User-Facing Changes
Tests + Formatting
After Submitting