Fix/input suppress output on windows #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
added
platform-specific
sholderbach
approved these changes
Jun 17, 2023
Comment on lines
+136
to
+140
| // clear terminal events | ||
| while crossterm::event::poll(Duration::from_secs(0))? { | ||
| // If there's an event, read it to remove it from the queue | ||
| let _ = crossterm::event::read()?; | ||
| } |
There was a problem hiding this comment.
I am not sure if this might become problematic if you try to run the whole thing in a "scripted" way (e.g. through pexpect or similar tools) if the buffer gets filled quicker than a human would typically type it in.
There was a problem hiding this comment.
Good point, I'll make some tests !
| crossterm::terminal::disable_raw_mode()?; | ||
| return Err(ShellError::IOError("SIGINT".to_string())); | ||
| Ok(Event::Key(k)) => match k.kind { | ||
| KeyEventKind::Press | KeyEventKind::Repeat => { |
|
fyi - i tested this on Windows 10 and it fixes the issue described in #9018. Thanks! |
|
Let's land it to benefit from the obvious fix and revisit any potential edge cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should close #9018
Description
This PR aims to fix the
inputcommand with--suppress-outputon WindowsThis fixes two separates issues :
input -s "blah :"still being in the event buffer (need to be cleared before reading keypresses)Tests + Formatting
cargo fmt --all -- --check✔️cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err✔️cargo test --workspace✔️cargo run -- crates/nu-std/tests/run.nu✔️