Update Contributing.md stating we can not accept PRs that are GPL #9483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think APACHE 2.0 is viable as well but we should talk more about it. |
|
@fdncred correct and so I specifically stated the couple of sentences in such a way that we are not saying "we do not include Apache..." But the only no/no is GPL... Of course we could add more verbiage to this section... I just thought we could start with this and "take it from there" Thanks for your thoughtful feedback 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently someone submitted a PR that included a crate that used the GPL license.
To avoid this happening in the future we updated the Contributing.md document stating
this specifically so people will not be confused about our policy.