Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make history.max_size bigger #9494

Merged
merged 2 commits into from Jun 23, 2023
Merged

make history.max_size bigger #9494

merged 2 commits into from Jun 23, 2023

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Jun 21, 2023

Description

make history.max_size bigger so it doesn't eat history

closes #9493

User-Facing Changes

Tests + Formatting

After Submitting

make history.max_size bigger so it doesn't eat history

closes #9493
Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this solves the issue of the OP (and that virtualenv stops being annoying...), i'm all for it 👌

@fdncred fdncred merged commit a0dafcb into main Jun 23, 2023
17 of 20 checks passed
@fdncred fdncred deleted the fdncred-patch-1 branch June 23, 2023 00:42
fnordpig pushed a commit to fnordpig/nushell that referenced this pull request Jun 23, 2023
# Description

make history.max_size bigger so it doesn't eat history

closes nushell#9493

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the
standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have no history size by default
2 participants