cratification: move the bytes command to nu-cmd-extra #9509
Conversation
| pub(crate) mod add; | ||
| pub(crate) mod at; | ||
| pub(crate) mod build_; | ||
| pub(crate) mod bytes_; | ||
| pub(crate) mod collect; | ||
| pub(crate) mod ends_with; | ||
| pub(crate) mod index_of; | ||
| pub(crate) mod length; | ||
| pub(crate) mod remove; | ||
| pub(crate) mod replace; | ||
| pub(crate) mod reverse; | ||
| pub(crate) mod starts_with; |
There was a problem hiding this comment.
What is the need to make this blanket visible? There have been recently a number of compiler warnings due to potential namespace conflicts due to many similar named symbols imported via use module::* that arise from symbols being public.
There was a problem hiding this comment.
@sholderbach thanks great catch ! I made your requested changes....
|
@amtoine I know you are moving this weekend and @sholderbach kindly reviewed the PR so I am going to go ahead and land this... I am going to circle back on to the bits commands after this lands and make the same changes @sholderbach suggested for this PR on the visibility issue of not needing the blanket pub(crate) which I corrected in this PR thanks to his suggestion. |
sholderbach
added
the
pr:breaking-change
In the spirit of #9509 we are changing the visibility of the bits commands to align with the way they are correctly done in the bytes commands... Thanks to @sholderbach for pointing out this nice improvement to me in my PR earlier in the day... ```rust mod and; mod bits_; mod not; mod or; mod rotate_left; mod rotate_right; mod shift_left; mod shift_right; mod xor; ```
|
thanks @stormasm and @sholderbach for backing me up on that one, really appreciate 🐘 ❤️ |
|
and it looks all good and working as expected to me, nice job @stormasm 😊 |
now that #9455 has landed we can move the bytes command to nu-cmd-extra
in concert with
moving nu_command::util to nu-cmd-base