Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cratification: part II of the math commands to nu-cmd-extra #9657

Merged
merged 1 commit into from Jul 11, 2023
Merged

cratification: part II of the math commands to nu-cmd-extra #9657

merged 1 commit into from Jul 11, 2023

Conversation

stormasm
Copy link
Contributor

The following math commands are being moved to nu-cmd-extra

  • cos
  • cosh
  • egamma
  • phi
  • pi
  • sin
  • sinh
  • tan
  • tanh
  • tau

For now I think we have most of the obvious commands moved over based on

@sholderbach this should cover moving the "high school" commands..

Yeah I think this rough separation into "high school" math in extra and "middle school"/"programmer" math in the core makes a ton of sense.

And to reference the @fdncred list from #9647 (comment)

@amtoine amtoine added pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes cratification labels Jul 11, 2023
@stormasm stormasm merged commit 942c66a into nushell:main Jul 11, 2023
19 checks passed
@stormasm stormasm deleted the mathsin branch July 11, 2023 18:23
@amtoine
Copy link
Member

amtoine commented Jul 12, 2023

little note about that PR, it does not remove math egamma and math phi from core because these did not appear to be exported in the default context 🤔
now they are properly in the extra feature, thanks @stormasm 😊

@stormasm
Copy link
Contributor Author

@amtoine yes, great point ! thanks for adding that to the comments 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cratification pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants