Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow mut to take pipelines #9658

Merged
merged 1 commit into from
Jul 11, 2023
Merged

allow mut to take pipelines #9658

merged 1 commit into from
Jul 11, 2023

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Jul 11, 2023 •
edited

Description

This extends the syntax fix for let (#9589) to mut as well.

Example: mut x = "hello world" | str length; print $x

closes #9634

User-Facing Changes

mut now joins let in being able to be assigned from a pipeline

Tests + Formatting

After Submitting

@sophiajt sophiajt merged commit ad11e25 into nushell:main Jul 11, 2023
19 checks passed
@sophiajt sophiajt deleted the mut_pipelines branch July 11, 2023 18:36
@amtoine
Copy link
Member

amtoine commented Jul 12, 2023

thanks @jntrnr for finishing this 😊

@amtoine amtoine mentioned this pull request Jul 12, 2023
Merged
sholderbach pushed a commit that referenced this pull request Jul 12, 2023
@amtoine
simplify the test for let core command (#9671)
545697c 
related to
- follow-up of #9658
- addressed part of #8670

# Description
removes useless `cwd` and `pipeline()` from the tests of `let`.

# User-Facing Changes
# Tests + Formatting
# After Submitting
@amtoine amtoine mentioned this pull request Jul 15, 2023
Open
@1Kinoti 1Kinoti mentioned this pull request Jul 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sophiajt @amtoine