Starship prompt #970
Starship prompt #970
Conversation
Kind of touches on nushell#356 by integrating the Starship prompt directly into the shell. Not finished yet and has surfaced a potential bug in rustyline anyway. It depends on starship/starship#509 being merged so the Starship prompt can be used as a library. I could have tackled nushell#356 completely and implemented a full custom prompt feature but I felt this was a simpler approach given that Starship is both written in Rust so shelling out isn't necessary and it already has a bunch of useful features built in. However, I would understand if it would be preferable to just scrap integrating Starship directly and instead implement a custom prompt system which would facilitate simply shelling out to Starship.
This resolves a small integration issue that would make custom prompts problematic (if they are implemented). The approach was to use the highlighter implementation in Helper to insert colour codes to the prompt however it heavily relies on the prompt being in a specific format, ending with a `> ` sequence. However, this should really be the job of the prompt itself not the presentation layer. For now, I've simply stripped off the additional `> ` characters and passed in just the prompt itself without slicing off the last two characters. I moved the `\x1b[m` control sequence to the prompt creation in `cli.rs` as this feels like the more logical home for controlling what the prompt looks like. I can think of better ways to do this in future but this should be a fine solution for now. In future it would probably make sense to completely separate prompts (be it, internal or external) from this code so it can be configured as an isolated piece of code.
|
|
|
@Southclaws - I know you had some additional things you wanted to add to make the experience even better from Nu, and I'm definitely 👍 for that. I just wanted to see if I could get your baseline working, and then we could grow from there. |
|
I'm having trouble figuring out how to enable the starship prompt. The documentation only explains how to configure the starship prompt once it's enabled, not how to enable it. I'm using 0.6.0 installed via Homebrew. |
|
The Fedora build appears to have the same issue. |
|
It's behind a feature-flag |
Would you be so kind as to show how that would look like, i.e. what commands or CLI options I would have to use to do so? As someone who is aware of Rust, but never worked directly with it, I'd greatly appreciate the extra guidance. 😄 |
|
@waldyrious - I'll update the blog post with installation steps |
|
The Fedora package is built with Shouldn't this include |
I appreciate the update to the blog post, but the command seems to be slightly off. Instead of I've also created a PR to Homebrew to enable the starship prompt there as well. |
Make starship prompt an optional feature for Nu. Builds on work by @Southclaws
Closes #804