Add functions for each Value case
#9736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to these changes. I think it cleans up our code a bit. Thanks! |
fdncred
added
the
pr:breaking-change
amtoine
reviewed
Jul 21, 2023
|
i labeled it a breaking change because the api is changing. |
ooh ok, the API of the crates, makes sense 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures functions exist to extract and create each and every
Valuecase. It also renamesValue::booleantoValue::boolto matchValue::test_bool,Value::as_bool, andValue::Bool. Similarly,Value::as_integerwas renamed toValue::as_intto be consistent withValue::int,Value::test_int, andValue::Int. These two renames can be undone if necessary.User-Facing Changes
No user facing changes, but two public functions were renamed which may affect downstream dependents.