Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the rest variable to the correct type #9816

Merged
merged 1 commit into from Jul 26, 2023

Conversation

sophiajt
Copy link
Member

Description

This fixes the type of $rest to be a List<...> so that it properly is checked in function bodies.

fixes #9809

User-Facing Changes

Tests + Formatting

After Submitting

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving this ❤️

@amtoine
Copy link
Member

amtoine commented Jul 26, 2023

yeah it fixes my edit command, really nice 👌

@sholderbach sholderbach added parser Issues related to parsing type-system Problems or features related to nushell's type system labels Jul 26, 2023
@sholderbach sholderbach merged commit f8d325d into nushell:main Jul 26, 2023
19 checks passed
@sophiajt sophiajt deleted the rest_var_correct_type branch July 26, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Issues related to parsing type-system Problems or features related to nushell's type system
Projects
None yet
3 participants