Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old deprecated commands #9840

Merged
merged 4 commits into from Aug 6, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jul 28, 2023

Description

in this PR i propose to remove the following old deprecated commands

  • hash base64 -> encode base64
  • math eval -> math <sub>
  • str to-datetime -> into datetime
  • str to-decimal -> into decimal
  • str find-replace -> str replace
  • str to-int -> into int
  • keep -> take
  • match -> find
  • nth -> select
  • pivot -> transpose
  • unalias -> hide
  • all? -> all
  • any? -> any
  • empty? -> is-empty
  • build-string -> str join / string concatenation with +
  • str lpad -> fill
  • str rpad -> fill
  • str collect -> str join
  • old-alias -> alias

so old i do not remember them at all 😮

i left the following four commands because they have been moved much more recently i think!

  • fetch -> http get
  • post -> http post
  • benchmark -> timeit
  • let-env
  • date format -> format date

User-Facing Changes

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • toolkit test
  • toolkit test stdlib

After Submitting

Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still miss pivot. It was so much easier to type.

@sholderbach sholderbach added the pr:release-note-mention Addition/Improvement to be mentioned in the release notes label Jul 28, 2023
@sophiajt
Copy link
Member

@fdncred maybe we need one called turn or rotate :D

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead with this! In my view this is not a breaking change as it doesn't affect behavior we advertise as working.

this should solve the merge conflict in nushell#9840 by leaving deprecated
the `date format` command which has been deprecated in nushell#9022.
this commit also renames `LetEnvDeprecated` to `LetEnv` for
consistency.
@amtoine
Copy link
Member Author

amtoine commented Aug 4, 2023

after the merge with the date format change i've just

  • removed the old-alias command which i forgot
  • left the date format -> format date deprecation as it's so recent
  • renamed LetEnvDeprecated to LetEnv
  • moved LetEnv and DateFormat to the "deprecated" section of default_context.rs

@fdncred fdncred merged commit dcb1a19 into nushell:main Aug 6, 2023
19 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Aug 6, 2023

Thanks

@amtoine amtoine deleted the remove-old-deprecated-commands branch August 7, 2023 07:34
fdncred pushed a commit that referenced this pull request Mar 27, 2024
# Description

I changed some help outputs:


![image](https://github.com/nushell/nushell/assets/30557287/d25f0fbe-ffc3-43b3-93cf-b1793d2351b6)


![image](https://github.com/nushell/nushell/assets/30557287/acb5581c-8959-4916-8a55-d3ed6a2e1dcf)

I also checked with `rg` the commands deprecated in #9840 and found a
help or a comment here and there.

# User-Facing Changes

same of above

# Tests + Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:release-note-mention Addition/Improvement to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants