New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove old deprecated commands #9840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still miss pivot. It was so much easier to type.
@fdncred maybe we need one called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead with this! In my view this is not a breaking change as it doesn't affect behavior we advertise as working.
this should solve the merge conflict in nushell#9840 by leaving deprecated the `date format` command which has been deprecated in nushell#9022.
this commit also renames `LetEnvDeprecated` to `LetEnv` for consistency.
after the merge with the
|
Thanks |
# Description I changed some help outputs: ![image](https://github.com/nushell/nushell/assets/30557287/d25f0fbe-ffc3-43b3-93cf-b1793d2351b6) ![image](https://github.com/nushell/nushell/assets/30557287/acb5581c-8959-4916-8a55-d3ed6a2e1dcf) I also checked with `rg` the commands deprecated in #9840 and found a help or a comment here and there. # User-Facing Changes same of above # Tests + Formatting
Description
in this PR i propose to remove the following old deprecated commands
hash base64
->encode base64
math eval
->math <sub>
str to-datetime
->into datetime
str to-decimal
->into decimal
str find-replace
->str replace
str to-int
->into int
keep
->take
match
->find
nth
->select
pivot
->transpose
unalias
->hide
all?
->all
any?
->any
empty?
->is-empty
build-string
->str join
/ string concatenation with+
str lpad
->fill
str rpad
->fill
str collect
->str join
old-alias
->alias
so old i do not remember them at all 😮
i left the following four commands because they have been moved much more recently i think!
fetch
->http get
post
->http post
benchmark
->timeit
let-env
date format
->format date
User-Facing Changes
Tests + Formatting
toolkit fmt
toolkit clippy
toolkit test
toolkit test stdlib
After Submitting