Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the panic when type a statement similar to let f = 'f' $ in the nushell #9851

Merged
merged 3 commits into from Aug 1, 2023
Merged

Fixed the panic when type a statement similar to let f = 'f' $ in the nushell #9851

merged 3 commits into from Aug 1, 2023

Conversation

mengsuenyan
Copy link
Contributor

@mengsuenyan mengsuenyan commented Jul 29, 2023

fixed the following bugs:

# type following statements in the nushell
let f = 'f' $;
mut f = 'f' $;
const f = 'f' $;

# then remove variable f, it will panics
let = 'f' $;
mut  = 'f' $;
const = 'f' $;

@mengsuenyan mengsuenyan changed the title Fix/9826 panic when let no var Fixed the panic when type like let f = 'f' $ in the nushell Jul 29, 2023
@mengsuenyan mengsuenyan changed the title Fixed the panic when type like let f = 'f' $ in the nushell Fixed the panic when type statement similar to let f = 'f' $ in the nushell Jul 29, 2023
@mengsuenyan mengsuenyan changed the title Fixed the panic when type statement similar to let f = 'f' $ in the nushell Fixed the panic when type a statement similar to let f = 'f' $ in the nushell Jul 29, 2023
@sophiajt
Copy link
Member

Can you add tests to this to ensure it's working?

@sophiajt
Copy link
Member

sophiajt commented Aug 1, 2023

thanks!

@sophiajt sophiajt merged commit fea8227 into nushell:main Aug 1, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in parser when backspacing over variable name nushell panics if I type let = if $
2 participants