Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged overloaded commands #9860

Merged
merged 15 commits into from Jul 31, 2023
Merged

Conversation

ayax79
Copy link
Contributor

@ayax79 ayax79 commented Jul 29, 2023

Description

This pull request merges all overloaded dfr commands into one command:

eager:
dfr first -> eager/first.rs
dfr last -> eager/last.rs
dfr into-nu -> eager/to_nu.rs (merged)

lazy:
dfr min -> expressions/expressions_macro.rs lazy_expressions_macro
dfr max -> expressions/expressions_macro.rs lazy_expressions_macro
dfr sum -> expressions/expressions_macro.rs lazy_expressions_macro
dfr mean -> expressions/expressions_macro.rs lazy_expressions_macro
dfr std -> expressions/expressions_macro.rs lazy_expressions_macro
dfr var -> expressions/expressions_macro.rs lazy_expressions_macro

series:
dfr n-unique -> series/n_unique.rs
dfr is-not-null -> series/masks/is_not_null.rs
dfr is-null -> series/masks/is_null.rs

User-Facing Changes

No user facing changes

…n explicit test case. This was needed so that the dataframe ane expression tests work correctly"
@amtoine
Copy link
Member

amtoine commented Jul 30, 2023

hi @ayax79 👋 😋
thanks again for working on the dataframes 🙏

could you make the title of the PR a bit smaller so that it fits in one line? 😋
it looks like it's the first commit's title which is a bit too long 😮

i'll mark this as a DRAFT for now as you have a "WIP" in the description 😌

@amtoine amtoine marked this pull request as draft July 30, 2023 09:09
@fdncred fdncred changed the title "created a new macro that unifies the lazy dataframe command with the… created a new macro that unifies the lazy dfr commands with expr df commands Jul 30, 2023
@fdncred fdncred changed the title created a new macro that unifies the lazy dfr commands with expr df commands created a new macro that unifies the lazy dfr commands with expr dfr commands Jul 30, 2023
@fdncred
Copy link
Collaborator

fdncred commented Jul 30, 2023

Most of the conversations related to this PR are here https://discord.com/channels/601130461678272522/1134562453817151528

@WindSoilder
Copy link
Collaborator

WindSoilder commented Jul 30, 2023

Thanks for the pr! I like it very much.

@ayax79 ayax79 changed the title created a new macro that unifies the lazy dfr commands with expr dfr commands Merged overloaded commands Jul 31, 2023
@ayax79
Copy link
Contributor Author

ayax79 commented Jul 31, 2023

@amtoine, updated and the PR is ready to go.

@ayax79 ayax79 marked this pull request as ready for review July 31, 2023 06:47
vec![
Example {
description:
"Var value from columns in a dataframe or aggregates columns to their var value",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the updated description :-)

Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I think dfrs are still a bit of a mess but this at least gets us back to working order. Thanks so much for putting in the time and effort to get us to this point @ayax79!

@fdncred fdncred merged commit 87abfee into nushell:main Jul 31, 2023
19 checks passed
@sholderbach sholderbach added the pr:release-note-mention Addition/Improvement to be mentioned in the release notes label Aug 22, 2023
@ayax79 ayax79 deleted the 9807_lazy_expression_commands branch February 15, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:release-note-mention Addition/Improvement to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dfr min stoped working with dfr col in 0.83.0
5 participants