New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged overloaded commands #9860
Conversation
… expression command"
…n explicit test case. This was needed so that the dataframe ane expression tests work correctly"
hi @ayax79 👋 😋 could you make the title of the PR a bit smaller so that it fits in one line? 😋 i'll mark this as a DRAFT for now as you have a "WIP" in the description 😌 |
Most of the conversations related to this PR are here https://discord.com/channels/601130461678272522/1134562453817151528 |
Thanks for the pr! I like it very much. |
@amtoine, updated and the PR is ready to go. |
vec![ | ||
Example { | ||
description: | ||
"Var value from columns in a dataframe or aggregates columns to their var value", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the updated description :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I think dfrs are still a bit of a mess but this at least gets us back to working order. Thanks so much for putting in the time and effort to get us to this point @ayax79!
dfr min
stoped working withdfr col
in 0.83.0 #9807Description
This pull request merges all overloaded dfr commands into one command:
eager:
dfr first -> eager/first.rs
dfr last -> eager/last.rs
dfr into-nu -> eager/to_nu.rs (merged)
lazy:
dfr min -> expressions/expressions_macro.rs lazy_expressions_macro
dfr max -> expressions/expressions_macro.rs lazy_expressions_macro
dfr sum -> expressions/expressions_macro.rs lazy_expressions_macro
dfr mean -> expressions/expressions_macro.rs lazy_expressions_macro
dfr std -> expressions/expressions_macro.rs lazy_expressions_macro
dfr var -> expressions/expressions_macro.rs lazy_expressions_macro
series:
dfr n-unique -> series/n_unique.rs
dfr is-not-null -> series/masks/is_not_null.rs
dfr is-null -> series/masks/is_null.rs
User-Facing Changes
No user facing changes