Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorification: move uncategorized String commands to Category::Strings #9931

Merged
merged 1 commit into from Aug 6, 2023
Merged

Categorification: move uncategorized String commands to Category::Strings #9931

merged 1 commit into from Aug 6, 2023

Conversation

stormasm
Copy link
Contributor

@stormasm stormasm commented Aug 6, 2023

In an effort to go through and review all of the remaining commands to find anything else that could possibly
be moved to nu-cmd-extra

I noticed that there are still some commands that have not been categorized...

I am going to Categorize the remaining commands that still do not have Category homes

In PR land I will call this Categorification as a play off of Cratification

  • str substring
  • str trim
  • str upcase

were in the default category because for some reason they had not yet been categorized.
I went ahead and moved them to the

.category(Category::Strings)

@sophiajt sophiajt merged commit fa2d9a8 into nushell:main Aug 6, 2023
19 checks passed
@stormasm stormasm deleted the catstring branch August 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants