Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move format duration/filesize back into core #9978

Merged
merged 1 commit into from Aug 10, 2023

Conversation

sholderbach
Copy link
Member

Description

Those two commands are very complementary to into duration and into filesize when you want to coerce a particular string output.

This keeps the old format command with its separate formatting syntax
still in nu-cmd-extra.

User-Facing Changes

format filesize is back accessible with the default build. The new format duration command is also available to everybody

Tests + Formatting

Those two commands are very complementary to `into duration` and `into
filesize` when you want to coerce a particular string output.

This keeps the old `format` command with its separate formatting syntax
still in `nu-cmd-extra`.
Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I agree. I've been thinking the same thing.

@sophiajt sophiajt merged commit a0cecf7 into nushell:main Aug 10, 2023
19 checks passed
@sholderbach sholderbach deleted the format-cmds-in-core branch August 10, 2023 20:08
@sholderbach sholderbach added the pr:release-note-mention Addition/Improvement to be mentioned in the release notes label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cratification pr:release-note-mention Addition/Improvement to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants