Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct cursor position if linewrapping occurs at the bottom of the screen #176

Closed
sholderbach opened this issue Nov 7, 2021 · 1 comment
Closed

Correct cursor position if linewrapping occurs at the bottom of the screen #176

sholderbach opened this issue Nov 7, 2021 · 1 comment
Labels
A-Cursor Area: Correct cursor handling (e.g. calculation of cursor position) A-Display Area: Correctness of the display output and additional features needed there bug Something isn't working P-high High Priority: Annoying bug, should be addressed with the next release
Projects
Get reedline engine-q ready

Comments

@sholderbach
Copy link
Member

The cursor position has to be correctly calculated/updated if the line wraps and the screen coordinate changes as the extra line shifts everything at the bottom of the screen.

Constant polling of the crossterm::cursor::position has to be avoided as this causes a serve hit to performance.
When approximations are performed this needs to be flexible enough to take potential change to sizes of things into account:
@sholderbach sholderbach added the bug Something isn't working label Nov 7, 2021
sholderbach added a commit to sholderbach/reedline that referenced this issue Nov 7, 2021
@sholderbach
Remove broken wrapping logic
4010656 
The exiting line wrapping logic does not solve the issue described in nushell#176 but the constant polling of position as soon as the cursor reached the first line ending causes performance issues
sholderbach added a commit to sholderbach/reedline that referenced this issue Nov 7, 2021
@sholderbach @sophiajt
Remove broken wrapping logic
fa5d012 
The exiting line wrapping logic does not solve the issue described in nushell#176 but the constant polling of position as soon as the cursor reached the first line ending causes performance issues

Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
sholderbach added a commit to sholderbach/reedline that referenced this issue Nov 9, 2021
@sholderbach @sophiajt
Remove broken wrapping logic
317d0b5 
The exiting line wrapping logic does not solve the issue described in nushell#176 but the constant polling of position as soon as the cursor reached the first line ending causes performance issues

Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
@sholderbach sholderbach added A-Display Area: Correctness of the display output and additional features needed there A-Cursor Area: Correct cursor handling (e.g. calculation of cursor position) P-high High Priority: Annoying bug, should be addressed with the next release labels Nov 28, 2021
@sholderbach sholderbach added this to High priority in Get reedline engine-q ready Nov 28, 2021
@sholderbach sholderbach mentioned this issue Nov 28, 2021
Closed
@sholderbach
Copy link
Member Author

Seems to be resolved for now

Get reedline engine-q ready automation moved this from High priority to Closed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Cursor Area: Correct cursor handling (e.g. calculation of cursor position) A-Display Area: Correctness of the display output and additional features needed there bug Something isn't working P-high High Priority: Annoying bug, should be addressed with the next release
Projects
Get reedline engine-q ready
  
Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sholderbach