fn queue_buffer probably didn't mean to flush; Simplified engine->insert_char and removed the need to create a String at each insert.
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-59
changed the title
fn queue_buffer probably didn't mean to flush :)fn queue_buffer probably didn't mean to flush; Simplified engine->insert_char and removed the need to create a String at each insert.
|
Thanks for the PR! looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry: Still new to all this Github machinery!
But, have eliminated the need to create a new String at each character insert.
Since we have separated the manipulation of the underlying buffer from the act of painting it, there's no harm in inserting the character into the buffer, then inspecting that.
Moreover, tried to make the code for 'insert char' more readable, and to simplify the interfaces.