Minimal enum to address #18 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse outer Result for error handling only pass the special case signals.
* support exit via `exit` or `logout` * Clear buffer on pressing Ctrl-c * move one line down on Ctrl-c * Handling by main maybe suboptimal
sophiajt
reviewed
Mar 16, 2021
src/engine.rs
Outdated
| pub enum Signal { | ||
| SUCCESS(String), | ||
| SIGINT, // Typically Ctrl-c | ||
| EOF, // Typically Ctrl-d |
There was a problem hiding this comment.
I think you could use CtrlC and CtrlD here instead of SIGINT/EOF. Helps with the readability and probably is a little more accurate if we're running on a platform without signals.
|
Just a couple nits. Should be good after that and resolving the conflict. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse outer Result for error handling only pass the special case
signals.