Allow configuration of multiline prompt color #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkf
commented
Jan 13, 2023
Comment on lines
-43
to
+49
| let prompt_style = Style::new().fg(Color::LightBlue); | ||
|
|
||
| let multiline_prompt = prompt.render_prompt_multiline_indicator(); | ||
| let prompt_style = Style::new().fg(prompt.get_prompt_multiline_color()); |
There was a problem hiding this comment.
This is the heart of the change. Instead of fixing this to Color::LightBlue, it is instead configured in Prompt::get_prompt_multiline_color().
dgkf
commented
Jan 13, 2023
Comment on lines
+110
to
+112
| fn get_prompt_multiline_color(&self) -> nu_ansi_term::Color { | ||
| DEFAULT_PROMPT_MULTILINE_COLOR | ||
| } |
There was a problem hiding this comment.
Added a new function to the Prompt to allow for it fetch a color. For now it uses a nu_ansi_term::Color unlike the others.
sholderbach
approved these changes
Jan 26, 2023
new lints from rust 1.67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color of the multiline prompt is currently hard-coded to be
LightBlue. This ended up being a pretty straightforward change to allow it to be configured using thePrompttrait similar to the other prompt colors.One oddity in here is that the multiline prompt uses a
nu_ansi_term::Color, whereas the other colors use acrossterm::style::Color. I'm not sure which one is preferred at this point, but I'd be willing to work toward some consistency if there's a current direction toward one or the other.