Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to make work with new lines embedded in sent string. #588

Merged
merged 2 commits into from May 30, 2023

Conversation

fnordpig
Copy link
Contributor

Currently if a sent string doesn't contain \r, it just prints on a new line without the carriage return:

This is the expected output:

This fixes that by always splitting the received line into lines. The example is updated to demonstrate.

src/engine.rs Show resolved Hide resolved
@fdncred
Copy link
Collaborator

fdncred commented May 30, 2023

ok, let's try it out. thanks!

@fdncred fdncred merged commit 79778f7 into nushell:main May 30, 2023
6 checks passed
@fnordpig fnordpig deleted the external_printer_bug branch May 30, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants