Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening the downloaded file works only on MacOS #11

Open
nielstron opened this issue Nov 22, 2019 · 0 comments · May be fixed by #12
Open

Opening the downloaded file works only on MacOS #11

nielstron opened this issue Nov 22, 2019 · 0 comments · May be fixed by #12

Comments

@nielstron
Copy link
Contributor

As pointed out in #9, the open subprocess called after successfully downloading all files does not work on all distributions.

It turns out that open is an OSX specific command to open a file in the associated application¹.
The command xdg-open exists on some UNIX systems, and there is a python library to call it in a more secure way². Yet this seems like a bit of an overhead.
The Windows equivalent seems to be start ³.

It would be nice to cover all distributions which seems to be covered by this approach: https://stackoverflow.com/a/435669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant