Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import timetable "undo" does not work #3475

Closed
leslieyip02 opened this issue Jul 31, 2023 · 1 comment
Closed

Import timetable "undo" does not work #3475

leslieyip02 opened this issue Jul 31, 2023 · 1 comment
Labels

Comments

@leslieyip02
Copy link
Contributor

Describe the bug

After importing a timetable shared via URL, the "UNDO" button in the notifcation does not undo the import.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the "Timetable" tab and click the share "Share/Sync" button
  2. Copy the URL, and open it in a different window
  3. Click "Import"
  4. Wait for the notification and click "UNDO"

Expected behavior

The undo button should reset the timetable to the previously saved state.

Video

undo-bug.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Tested on Chrome and Firefox
  • Version: 22H2

Additional context

This is where the "undo" notifcation is dispatched:

dispatch(
openNotification('Timetable imported', {
timeout: 12000,
overwritable: true,
action: {
text: 'Undo',
handler: () => dispatch(undo) as never,
},
}),
);

@zwliew
Copy link
Member

zwliew commented Aug 5, 2023

Fixed in #3492. Thanks for reporting this :D

@zwliew zwliew closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants