Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'RightShift' key is mapped to space? #442

Closed
musab1234 opened this issue Oct 23, 2022 · 1 comment
Closed

'RightShift' key is mapped to space? #442

musab1234 opened this issue Oct 23, 2022 · 1 comment
Labels
bug Something isn't working DONE Implementation is done, but not yet merged into master

Comments

@musab1234
Copy link

'RightShift' is mapped to space in code. See:

nut.js/lib/provider/native/libnut-keyboard.class.ts

Line 91 in bc5e99c

[Key.RightShift, "space"],

is there any specific reason or its just a mistake?
@s1hofmann
Copy link
Member

Hi @musab1234 👋

that’s a mistake, thanks for reporting!

Best regards

Simon

@s1hofmann s1hofmann added the bug Something isn't working label Oct 23, 2022
s1hofmann added a commit that referenced this issue Oct 23, 2022
@s1hofmann
(#442) Use correct mapping for right shift (right_shift instead of sp…
2ee2b17 
…ace)
@s1hofmann s1hofmann linked a pull request Oct 23, 2022 that will close this issue
(#442) Use correct mapping for right shift (right_shift instead of sp… #443
Merged
@s1hofmann s1hofmann removed a link to a pull request Oct 23, 2022
(#442) Use correct mapping for right shift (right_shift instead of sp… #443
Merged
s1hofmann added a commit that referenced this issue Oct 23, 2022
@s1hofmann
(#442) Use correct mapping for right shift (right_shift instead of sp…
267b421 
…ace) (#443)
@s1hofmann s1hofmann added the DONE Implementation is done, but not yet merged into master label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working DONE Implementation is done, but not yet merged into master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s1hofmann @musab1234