Add codecov.yml to ensure adequate patch coverage #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 6 6
Lines 330 330
=======================================
Hits 257 257
Misses 73 73 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
thunderboltsid
force-pushed
the
KRBN-7734
branch
7 times, most recently
from
30c4e0f
to
d8478f3
Compare
thunderboltsid
changed the title
thunderboltsid
force-pushed
the
KRBN-7734
branch
from
d8478f3
to
2079f51
Compare
thunderboltsid
changed the title
thunderboltsid
force-pushed
the
KRBN-7734
branch
from
2079f51
to
eab4449
Compare
|
build-container job is failing due to a Trivy scan stemming from CVE-2023-45142. Attempting to fix that in another PR #117 |
thunderboltsid
force-pushed
the
KRBN-7734
branch
from
eab4449
to
a720f04
Compare
adiantum
requested changes
Nov 13, 2023
This sets the minimum patch coverage required for changes to repo to 75%. There was a discrepancy between the Go version in go.mod and the go version in github actions workflow. This change also alleviates that discrepancy by changing the Go version in both to the latest Go version (v1.21).
thunderboltsid
force-pushed
the
KRBN-7734
branch
from
a720f04
to
eb1b7ee
Compare
✅ None of your dependencies violate policy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the minimum patch coverage required for changes to repo to 75%.
Existing code coverage is currently ~77% which is slightly above 75%.
There was a discrepancy between the Go version in go.mod
and the go version in github actions workflow. This change also
alleviates that discrepancy by changing the Go version in both to
the latest Go version (v1.21).
How has this been tested?
Added a dummy change to this PR that drops the overall coverage and has no patch coverage. this caused two failures (overall coverage drop & patch coverage below threshold).
Then removed the offending piece of dummy change and observed the codecov checks pass.