Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log node exists/shutdown status at default verbosity #118

Merged

Conversation

dlipovetsky
Copy link
Contributor

What this PR does / why we need it:
Previously, the controller logged two lines for every node approximately every 7 seconds, or about 1000 lines per node, per hour.

For example:

I1227 18:39:59.655871       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:00.115157       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:00.693491       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:01.242311       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:06.775496       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:07.264917       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:07.747176       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:08.179592       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:13.675784       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:14.156767       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:14.635342       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:15.065686       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:20.463439       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:20.963273       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:21.388286       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:21.864284       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:27.416278       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:27.998769       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:28.646187       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:29.131304       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:34.683511       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:35.118103       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:35.694925       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:36.122100       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:41.666251       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:42.244924       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:42.669489       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:43.234134       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:48.753024       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:49.212019       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:49.864969       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:50.358605       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:40:55.896952       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:40:56.365655       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:40:56.908435       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:40:57.474351       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:41:03.086870       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:41:03.708390       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:41:04.286242       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:41:04.694276       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:41:10.260410       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:41:10.911270       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:41:11.510154       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:41:12.153530       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:41:17.836055       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:41:18.429313       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:41:18.988415       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:41:19.486467       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:41:25.096248       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:41:25.613627       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!
I1227 18:41:26.205629       1 manager.go:190] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml exists!
I1227 18:41:26.784818       1 manager.go:211] Node my-cc-cluster-md-0-d8drs-g2hdp-q4xml is not shutdown!
I1227 18:41:32.304919       1 manager.go:190] Node my-cc-cluster-qh6fc-plnhl exists!
I1227 18:41:32.876564       1 manager.go:211] Node my-cc-cluster-qh6fc-plnhl is not shutdown!

Moreover, nearly identical messages are already logged in a different function, at verbosity level 1:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

Previously, the controller logged two lines for every node
approximately every 7 seconds, or about 1000 lines per node,
per hour.

Moreover, nearly identical messages are already logged in
a different function, at verbosity level 1.
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fc3562) 77.87% compared to head (9bf05d2) 77.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   77.87%   77.60%   -0.28%     
==========================================
  Files           6        6              
  Lines         330      326       -4     
==========================================
- Hits          257      253       -4     
  Misses         73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thunderboltsid thunderboltsid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thunderboltsid thunderboltsid merged commit a88565a into nutanix-cloud-native:main Jan 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants