Fix gh-actions for testing container build #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manavrajvanshi
requested review from
tuxtof,
akshmish,
shenoypritika and
yash-ntnx
akshmish
reviewed
May 24, 2023
akshmish
previously approved these changes
May 24, 2023
yash-ntnx
previously approved these changes
May 24, 2023
yash-ntnx
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The github actions do not cover the container build step. This PR adds the github action to test a container build for the changes in the push and pull_requests. As an example, the container-build for #102 should ideally fail but it passes due to the missing step.
How Has This Been Tested?:
This has been tested by pushing changes to a branch and verifying that the
Build Containertest step is executed.Release Notes: