Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to automatically unmap device memory in lm_ctx_destroy #36

Closed
tmakatos opened this issue Feb 4, 2020 · 1 comment
Closed

add option to automatically unmap device memory in lm_ctx_destroy #36

tmakatos opened this issue Feb 4, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tmakatos
Copy link
Member

tmakatos commented Feb 4, 2020

If device emulation has allocated device memory and does not unmap it after lm_ctx_destroy has been called, then the muser device cannot be removed until that memory is unmapped. This behavior is desirable in order to support restartable device emulation. However, there are cases where we'd like device emulation to go away and having lm_ctx_destroy automatically unmap such memory would make coding easier. My proposal is to add a flag in lm_ctx_destroy to unmap such memory (should be false by default).
@tmakatos tmakatos changed the title add option to automatically unmap device memory in lm_ctx_destroy add option to automatically unmap device memory in lm_ctx_destroy Feb 4, 2020
@tmakatos tmakatos added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2020
@tmakatos
Copy link
Member Author

We've switched to vfio-user and have dropped muser.ko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmakatos