Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imprv] add functionality to set network mac_address to module ntnx_vms #201

Closed
kenmoini opened this issue May 14, 2022 · 2 comments · Fixed by #272
Closed

[Imprv] add functionality to set network mac_address to module ntnx_vms #201

kenmoini opened this issue May 14, 2022 · 2 comments · Fixed by #272
Assignees
Labels
1.7 enhancement New feature or request
Projects

Comments

@kenmoini
Copy link
Contributor

Describe the request

Assigning MAC addresses to network interfaces is crucial for some workloads such as reserved DHCP requests and day 1 static networking in OpenShift with the Assisted Installer Service.

Current behaviour

Currently, the ntnx_vms module does not allow setting the MAC address property, only a private IP if it is a managed subnet.

Expected behaviour

Expected behavior should extend the subnet definition with a MAC Address to allow enterprise IPAM network mapping.

  - name: create Vm
    nutanix.ncp.ntnx_vms:
      state: present
      name: "ansible_automation_demo"
      networks:
        - is_connected: True
          mac_address: "50:6B:8D:69:42:04"
          subnet:
            name: "{{ subnet_name }}"
@kenmoini
Copy link
Contributor Author

For reference, I have the functionality employed in my fork in a separate branch: https://github.com/kenmoini/nutanix.ansible/tree/kenmoini-mac-address-patch

The code is there, it works, just need guidance on what remains to contribute via PR - I am unaware of what the Nutanix-side integration testing would require.

@bhati-pradeep bhati-pradeep added this to To do in 1.7.0 Sep 12, 2022
@alaa-bish alaa-bish linked a pull request Sep 13, 2022 that will close this issue
@bhati-pradeep bhati-pradeep moved this from To do to Done in 1.7.0 Sep 15, 2022
@bhati-pradeep bhati-pradeep moved this from Done to In Review in 1.7.0 Sep 15, 2022
@bhati-pradeep bhati-pradeep moved this from In Review to Done in 1.7.0 Sep 21, 2022
@bhati-pradeep
Copy link
Collaborator

Changes released in v1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7 enhancement New feature or request
Projects
No open projects
1.7.0
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants