Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subnet Name --> UUID Lookup should be PE Cluster Aware #260

Closed
jzamanski opened this issue Aug 25, 2022 · 1 comment · Fixed by #266 or #286
Closed

Subnet Name --> UUID Lookup should be PE Cluster Aware #260

jzamanski opened this issue Aug 25, 2022 · 1 comment · Fixed by #266 or #286
Assignees
@bhati-pradeep
Labels
1.7
Projects
1.7.0

Comments

@jzamanski
Copy link

The conversion from subnet name to UUID needs to filter on PE cluster as well as there can be subnets of the same name on each PE cluster. Currently it may retrieve the subnet UUID of a subnet with the same name but on a different PE cluster.

nutanix.ansible/plugins/module_utils/prism/vms.py

Line 251 in 06461f5

uuid = subnet.get_uuid(name)

@jzamanski jzamanski changed the title Subnet Name > UUID Lookup should be PE Cluster Aware Subnet Name --> UUID Lookup should be PE Cluster Aware Aug 25, 2022
@bhati-pradeep bhati-pradeep self-assigned this Sep 12, 2022
@bhati-pradeep bhati-pradeep added this to To do in 1.7.0 Sep 12, 2022
@bhati-pradeep bhati-pradeep linked a pull request Sep 12, 2022 that will close this issue
Consider cluster reference as well for getting subnet uuid #266
Merged
@bhati-pradeep bhati-pradeep moved this from To do to In progress in 1.7.0 Sep 15, 2022
@bhati-pradeep bhati-pradeep moved this from In progress to Done in 1.7.0 Sep 15, 2022
@bhati-pradeep bhati-pradeep moved this from Done to In Review in 1.7.0 Sep 15, 2022
@bhati-pradeep bhati-pradeep moved this from In Review to Done in 1.7.0 Sep 21, 2022
@bhati-pradeep bhati-pradeep linked a pull request Sep 28, 2022 that will close this issue
Handle overlay subnet case while filtering subnets in vms based on cluster #286
Merged
@bhati-pradeep
Copy link
Collaborator

Fixed in v1.7.0, checkout example vm.yml for usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhati-pradeep bhati-pradeep

Labels
1.7
Projects
No open projects
1.7.0
  
Done
Milestone
No milestone
2 participants
@jzamanski @bhati-pradeep