Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer diff interface in intent handlers #638

Open
shlomi-nx opened this issue Feb 24, 2021 · 0 comments
Open

Nicer diff interface in intent handlers #638

shlomi-nx opened this issue Feb 24, 2021 · 0 comments

Comments

@shlomi-nx
Copy link
Contributor

Get rid of the second-level nested array in diffs unless the diff type is actually an array (e.g. spec[0].diff[0] when diffing two strings)

  • It's confused me and everyone else I know who's had to learn it
  • It makes provider code harder to read / leads to smelly code (e.g. "why is [0] always hardcoded for the nested array?")

Some design is needed

It may be difficult to embed the schema in the differ itself, perhaps we need a second pass on the differ results which will run against the schema and flatten unneeded vectors.

@shlomi-nx shlomi-nx created this issue from a note in Customer-1's asks (Nice to have 1.0) Feb 24, 2021
@shlomi-nx shlomi-nx added this to the Customer-1 M2 milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Customer-1's asks
Nice to have 1.0
Development

No branches or pull requests

1 participant