Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running mode tests #482

Merged
merged 3 commits into from
Jun 5, 2023
Merged

running mode tests #482

merged 3 commits into from
Jun 5, 2023

Conversation

sergix44
Copy link
Member

@sergix44 sergix44 commented Jun 5, 2023

code climate fixes

[ci skip] [skip ci]
@sergix44 sergix44 requested a review from Lukasss93 as a code owner June 5, 2023 22:18
@codeclimate
Copy link

codeclimate bot commented Jun 5, 2023

Code Climate has analyzed commit 4465e3e and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (60% is the threshold).

This pull request will bring the total coverage in the repository to 96.3%.

View more on Code Climate.

* @return mixed
* @throws Throwable
*/
protected function fireHandlers(array $handlers, array $parameters = []): mixed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function fireHandlers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

@sergix44 sergix44 merged commit 6e740bb into master Jun 5, 2023
6 of 7 checks passed
@sergix44 sergix44 deleted the cc_fixes branch June 5, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant