Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iqsms sender signature #9

Merged
merged 2 commits into from
Mar 19, 2020
Merged

iqsms sender signature #9

merged 2 commits into from
Mar 19, 2020

Conversation

Dalamar
Copy link

@Dalamar Dalamar commented Mar 19, 2020

Feature request

iqsms - sender signature.

https://iqsms.ru/api/api_json/

sender |   | Подпись отправителя (например TEST)

@maximkou
Copy link
Contributor

Hi! Thank you for request!

I did some changes in your PR, could you check them?
Shortly, what I did:

  1. You forget to change sendBatch method
  2. In order to allow using other message parameters (not only sender, but for example flash or wapUrl), I change way to passing this options.

Now, usage example:

config:

// nutnet-laravel-sms.php
'providers' => [
    'iqsmsru' => [
        'login' => '<your_login>',
        'password' => '<your_password>',
        'message_defaults' => [
              'sender' => '<your sender name>',
              'flash' => 1
        ]
    ]
],

Code has no changes.

@Dalamar
Copy link
Author

Dalamar commented Mar 19, 2020

Ok
That's even better solution.

@maximkou maximkou merged commit c8b1ff2 into nutnetru:master Mar 19, 2020
@maximkou
Copy link
Contributor

Thanks! Merged and available in 0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants