Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add API authorizer #354

Merged
merged 6 commits into from
Mar 3, 2023
Merged

add API authorizer #354

merged 6 commits into from
Mar 3, 2023

Conversation

beardedfoo
Copy link
Contributor

@beardedfoo beardedfoo commented Feb 28, 2023 •
edited

Regarding #1821

reinkrul
reinkrul requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@reinkrul reinkrul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't help but feel this is overengineered for a demo app. Feels more like this would go into a generic Nuts node client lib/SDK?

config.go Outdated Show resolved Hide resolved
keyring/key.go Outdated Show resolved Hide resolved
keyring/key.go Outdated Show resolved Hide resolved
nuts/client/authorizer.go Outdated Show resolved Hide resolved
keyring/key.go Outdated Show resolved Hide resolved
keyring/key.go Outdated Show resolved Hide resolved
keyring/ssh_ecdsa_256_test.go Outdated Show resolved Hide resolved
@beardedfoo beardedfoo marked this pull request as ready for review March 3, 2023 08:17
reinkrul
reinkrul approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@reinkrul reinkrul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix go.mod replace

@beardedfoo beardedfoo requested a review from reinkrul March 3, 2023 14:15
@beardedfoo beardedfoo mentioned this pull request Mar 3, 2023
Closed
4 tasks
@beardedfoo beardedfoo merged commit 4253dd1 into main Mar 3, 2023
@reinkrul reinkrul deleted the feat/jwt-auth branch September 6, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinkrul reinkrul reinkrul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beardedfoo @reinkrul