Skip to content
This repository has been archived by the owner on Oct 3, 2022. It is now read-only.

Extract data classes from fhir with system and code #9

Merged
merged 3 commits into from Jan 6, 2020

Conversation

woutslakhorst
Copy link
Member

Only the code is currently extracted resulting in incorrect storage of the consent records in the store. This PR will also extract the system, it determines the divider in the resulting string based on the system. Namespace types get a # and urn types a :.

Fixes #8

Signed-off-by: Wout Slakhorst wout.slakhorst@nedap.com

Signed-off-by: Wout Slakhorst <wout.slakhorst@nedap.com>
@woutslakhorst woutslakhorst added this to Done in v0.11.2 Dec 20, 2019
@woutslakhorst woutslakhorst moved this from Done to Review in v0.11.2 Dec 20, 2019
Copy link
Member

@stevenvegt stevenvegt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the oid is now available in the core package, can we use that constant instead of duplicating it all over the code-base?

Signed-off-by: Wout Slakhorst <wout.slakhorst@nedap.com>
Signed-off-by: Wout Slakhorst <wout.slakhorst@nedap.com>
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #9 into master will increase coverage by 7.7%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/validation.go 62.02% <100%> (+15.44%) ⬆️

@woutslakhorst woutslakhorst merged commit 43690c0 into master Jan 6, 2020
@woutslakhorst woutslakhorst deleted the fix_data_classes_from_fhir branch January 6, 2020 13:37
@woutslakhorst woutslakhorst moved this from Review to Done in v0.11.2 Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
v0.11.2
  
Done
Development

Successfully merging this pull request may close these issues.

Resource extraction from fhir ignores the system
2 participants