Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether we want HTTP bind addresses per engine or just use the global config #14

Closed
reinkrul opened this issue Jan 25, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@reinkrul
Copy link
Member

Now each engine defines a HTTP bind address (or remote server address when running the client). The global config also defines the bind address. Since we don't plan to start just some modules per node (fine-grained microservices) but use the all-or-nothing approach, there's (imo) no need to specify a bind address per engine.

@woutslakhorst
Copy link
Member

Unless we want to bind internal API to a different interface. But that should be future work I think.

@reinkrul
Copy link
Member Author

reinkrul commented Jan 29, 2021

In that case these alternative ports are determined by the core/global config anyways, not per engine I think. So we get a map with API categories -> ports;

binds:
  public: 0.0.0.0:1323
  admin: localhost:9999
  internal: nuts-node.lan:2000

or something

@woutslakhorst
Copy link
Member

This issue only focusses on using a single address config for each engine!

@reinkrul
Copy link
Member Author

reinkrul commented Mar 3, 2021

Already fixed.

@reinkrul reinkrul closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants