Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow API calls to be bound to specific HTTP interfaces #56

Merged
merged 4 commits into from
Feb 12, 2021
Merged

Allow API calls to be bound to specific HTTP interfaces #56

merged 4 commits into from
Feb 12, 2021

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Feb 9, 2021 •
edited
Loading

Fixes #34

@codecov
Copy link

codecov bot commented Feb 9, 2021 •
edited
Loading

Codecov Report

Merging #56 (60ce874) into master (f40e63e) will increase coverage by 0.31%.
The diff coverage is 83.01%.

Impacted Files Coverage Δ
core/engine.go 91.37% <ø> (ø)
cmd/root.go 84.21% <61.11%> (+2.78%) ⬆️
core/echo.go 92.85% <92.85%> (ø)
core/metrics.go 77.77% <100.00%> (ø)
core/server_config.go 95.12% <100.00%> (+0.38%) ⬆️
core/status.go 100.00% <100.00%> (ø)

@reinkrul reinkrul force-pushed the http-interface-binding branch 2 times, most recently from 7bce185 to 647ded5 Compare February 10, 2021 08:33
@reinkrul reinkrul marked this pull request as ready for review February 11, 2021 06:25
woutslakhorst
woutslakhorst requested changes Feb 11, 2021
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run gofmt

al those router methods are the result of the oapi-codegen tool. Echo itself uses Add, maybe we can change oapi-codegen?

core/server_config.go Outdated Show resolved Hide resolved
core/echo.go Outdated Show resolved Hide resolved
core/echo_test.go Outdated Show resolved Hide resolved
cmd/root_test.go Outdated Show resolved Hide resolved
woutslakhorst
woutslakhorst approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner this way

@woutslakhorst
Copy link
Member

closes #14

@reinkrul reinkrul merged commit 248bd83 into master Feb 12, 2021
@reinkrul reinkrul deleted the http-interface-binding branch February 12, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

@stevenvegt stevenvegt Awaiting requested review from stevenvegt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bind different API security levels to different network interfaces
2 participants
@reinkrul @woutslakhorst