Add support for Verifiable Credentials #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
12 tasks
woutslakhorst
added a commit
that referenced
this pull request
Feb 24, 2021
author Wout Slakhorst <wout.slakhorst@nedap.com> 1613478142 +0100 committer Wout Slakhorst <wout.slakhorst@nedap.com> 1614170222 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE7J+WX+qKnh5/rHMTXC0I4qbxRDAFAmA2SG4ACgkQXC0I4qbx RDD9hQgAkReJ3lsQVNl3SJTwHFNLzK5cg6VYyD+m94Sf/lCNez5q0liE/rtZOznA 9GGhrf3d3l10RpjKeoTke+n57khXku9aMpGEhEwuNvramilP2NrcidHV0AIP/lPr 5Lswmy1Uvcc2MLNhc9ftGjcmTXHfrm9DTZFDjIgqQ12MyC0OXHDXsqWka1E0D8fN /4RVG5wf3sxcCgy0/q8CwKATDUerCLmHZEZSCSPCunszVv03blOFj/ZI+202HRSH DkLCnHm7i33iWUMye1dzZczFu1RIJCOxyOV2Qvw3KfOCLDP6FcF+2/3WZ9L8lGnm TeWz8I6hCaqnL7CYT3fJgmE1W7CuVQ== =oY0J -----END PGP SIGNATURE----- Added support for Verifiable Credentials: - concept mapping infrastructure - instance - search method on instance - api spec this is part of #69 updated nuts libs fixed generator go-did update and simplified API return for organization search add xperimental concept mapping added example integration for API and network Updated to latest version of go-did library (#72) Co-authored-by: Rein Krul <info@reinkrul.nl> No longer save pubKey in KeyCreator.New (#70) * No longer directly save a pubKey from in KeyCreator.New switched go-did back to improve-api branch something that compiles connected credential engine changed pub fields to methods and priv fields fixed template indexing code gofmt some comments add query tests completed query.go tests more template tests added first test set for credential store gofmt and goimport test fix ignore API for this PR codeclimate stuff more interfaces regen mocks gofmt:
woutslakhorst
force-pushed
the
iss66_add_vc
branch
from
aaf62fd
to
8a9c4ff
Compare
woutslakhorst
added a commit
that referenced
this pull request
Feb 24, 2021
author Wout Slakhorst <wout.slakhorst@nedap.com> 1613478142 +0100 committer Wout Slakhorst <wout.slakhorst@nedap.com> 1614170222 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE7J+WX+qKnh5/rHMTXC0I4qbxRDAFAmA2SG4ACgkQXC0I4qbx RDD9hQgAkReJ3lsQVNl3SJTwHFNLzK5cg6VYyD+m94Sf/lCNez5q0liE/rtZOznA 9GGhrf3d3l10RpjKeoTke+n57khXku9aMpGEhEwuNvramilP2NrcidHV0AIP/lPr 5Lswmy1Uvcc2MLNhc9ftGjcmTXHfrm9DTZFDjIgqQ12MyC0OXHDXsqWka1E0D8fN /4RVG5wf3sxcCgy0/q8CwKATDUerCLmHZEZSCSPCunszVv03blOFj/ZI+202HRSH DkLCnHm7i33iWUMye1dzZczFu1RIJCOxyOV2Qvw3KfOCLDP6FcF+2/3WZ9L8lGnm TeWz8I6hCaqnL7CYT3fJgmE1W7CuVQ== =oY0J -----END PGP SIGNATURE----- Added support for Verifiable Credentials: - concept mapping infrastructure - instance - search method on instance - api spec this is part of #69 updated nuts libs fixed generator go-did update and simplified API return for organization search add xperimental concept mapping added example integration for API and network Updated to latest version of go-did library (#72) Co-authored-by: Rein Krul <info@reinkrul.nl> No longer save pubKey in KeyCreator.New (#70) * No longer directly save a pubKey from in KeyCreator.New switched go-did back to improve-api branch something that compiles connected credential engine changed pub fields to methods and priv fields fixed template indexing code gofmt some comments add query tests completed query.go tests more template tests added first test set for credential store gofmt and goimport test fix ignore API for this PR codeclimate stuff more interfaces regen mocks gofmt:
woutslakhorst
force-pushed
the
iss66_add_vc
branch
from
8a9c4ff
to
7752e4b
Compare
woutslakhorst
changed the title
reinkrul
requested changes
Feb 25, 2021
|
@reinkrul there are some questions from me on some of the comments |
author Wout Slakhorst <wout.slakhorst@nedap.com> 1613478142 +0100 committer Wout Slakhorst <wout.slakhorst@nedap.com> 1614170222 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE7J+WX+qKnh5/rHMTXC0I4qbxRDAFAmA2SG4ACgkQXC0I4qbx RDD9hQgAkReJ3lsQVNl3SJTwHFNLzK5cg6VYyD+m94Sf/lCNez5q0liE/rtZOznA 9GGhrf3d3l10RpjKeoTke+n57khXku9aMpGEhEwuNvramilP2NrcidHV0AIP/lPr 5Lswmy1Uvcc2MLNhc9ftGjcmTXHfrm9DTZFDjIgqQ12MyC0OXHDXsqWka1E0D8fN /4RVG5wf3sxcCgy0/q8CwKATDUerCLmHZEZSCSPCunszVv03blOFj/ZI+202HRSH DkLCnHm7i33iWUMye1dzZczFu1RIJCOxyOV2Qvw3KfOCLDP6FcF+2/3WZ9L8lGnm TeWz8I6hCaqnL7CYT3fJgmE1W7CuVQ== =oY0J -----END PGP SIGNATURE----- Added support for Verifiable Credentials: - concept mapping infrastructure - instance - search method on instance - api spec this is part of #69 updated nuts libs fixed generator go-did update and simplified API return for organization search add xperimental concept mapping added example integration for API and network Updated to latest version of go-did library (#72) Co-authored-by: Rein Krul <info@reinkrul.nl> No longer save pubKey in KeyCreator.New (#70) * No longer directly save a pubKey from in KeyCreator.New switched go-did back to improve-api branch something that compiles connected credential engine changed pub fields to methods and priv fields fixed template indexing code gofmt some comments add query tests completed query.go tests more template tests added first test set for credential store gofmt and goimport test fix ignore API for this PR codeclimate stuff more interfaces regen mocks gofmt:
woutslakhorst
force-pushed
the
iss66_add_vc
branch
from
66e0c41
to
9895820
Compare
|
rebase required force push |
reinkrul
requested changes
Feb 26, 2021
woutslakhorst
moved this from In Progress
to In review
in Nuts Reference Implementation v1
reinkrul
approved these changes
Mar 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #66