Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : In BPTSparse when combination of bucket and key is repeated #207

Merged
merged 4 commits into from Sep 12, 2022
Merged

fix : In BPTSparse when combination of bucket and key is repeated #207

merged 4 commits into from Sep 12, 2022

Conversation

ShiMaRing
Copy link
Contributor

When a bucket and key are concatenated and duplicate, the value of the previous bucket is overwritten，by modifying the concatenation method, the duplicate occurrence can be avoided

        newKey = append(newKey, key...)

change to

	newKey = append(newKey, key...)
	newKey = append(newKey, []byte(bucket)...)

@ShiMaRing ShiMaRing changed the title Fix bug in BPTSparse when combination of bucket and key is repeated fix : In BPTSparse when combination of bucket and key is repeated Sep 10, 2022
xujiajun
xujiajun approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@xujiajun xujiajun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xujiajun xujiajun merged commit e849c7a into nutsdb:master Sep 12, 2022
@xujiajun xujiajun mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xujiajun xujiajun xujiajun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShiMaRing @xujiajun