pref: remove sync.Pool and prev allocate buffer for small tx #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merge another PR just now. And there is raising some conflicts in this PR. Could you help resolve them? Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
+ Coverage 60.46% 60.55% +0.09%
==========================================
Files 25 25
Lines 4320 4340 +20
==========================================
+ Hits 2612 2628 +16
- Misses 1494 1498 +4
Partials 214 214
|
bigboss2063
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #354, I have removed the usage of sync.pool. If it is a write transaction, it is always concurrency-safe. Instead, I have added a preallocated Buffer for reuse, and only transactions larger than this Buffer size will trigger a new Buffer.