Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair tx.SMembers bug #404

Merged
merged 14 commits into from
Aug 6, 2023
Merged

Conversation

damotiansheng
Copy link
Collaborator

  1. tx.SMembers func is not return data which is a bug, i have resolved this problem and fixed the unit test for this func

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #404 (25d3eb8) into master (a81dd1a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   62.39%   62.45%   +0.06%     
==========================================
  Files          31       31              
  Lines        5246     5247       +1     
==========================================
+ Hits         3273     3277       +4     
+ Misses       1688     1686       -2     
+ Partials      285      284       -1     
Files Changed Coverage Δ
tx_set.go 79.38% <100.00%> (+1.22%) ⬆️

@elliotchenzichang
Copy link
Member

Is that the batch wirte branch? Could you help push another PR?

@damotiansheng
Copy link
Collaborator Author

damotiansheng commented Aug 6, 2023 via email

@damotiansheng
Copy link
Collaborator Author

you mean i create a new branch and push this PR? the code diff is right

@elliotchenzichang elliotchenzichang merged commit 6cd9618 into nutsdb:master Aug 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants