[Test] Restart the database using three modes #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 62.39% 63.78% +1.39%
==========================================
Files 31 31
Lines 5246 5247 +1
==========================================
+ Hits 3273 3347 +74
+ Misses 1688 1604 -84
- Partials 285 296 +11 |
db_test.go
Outdated
| opt.EntryIdxMode = HintKeyValAndRAMIdxMode | ||
| opt.SegmentSize = 8 * 1024 | ||
|
|
||
| withDBOption(t, opt, func(t *testing.T, db *DB) { |
There was a problem hiding this comment.
I can recall that @bigboss2063 refacted the code which runs test case with customized database. Could you help also refactor this part of code when you have time? For more context and code style you can refer this artcle. Thanks！https://mp.weixin.qq.com/s/w8YaLU0b3bEzUXdrxezodQ
There was a problem hiding this comment.
And this is the related PR link! #375
merge_test.go
Outdated
| "sync" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
Why only added dependency in this file? Is that expected?
There was a problem hiding this comment.
I don't know, maybe my editor did it, I'll check it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.