Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented configurable automatic expiration deletion, optional time heap or time wheel #435

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

bigboss2063
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #435 (c0e916d) into master (37aa43e) will increase coverage by 0.17%.
The diff coverage is 88.07%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   66.90%   67.07%   +0.17%     
==========================================
  Files          33       34       +1     
  Lines        5820     5905      +85     
==========================================
+ Hits         3894     3961      +67     
- Misses       1583     1600      +17     
- Partials      343      344       +1     
Files Changed Coverage Δ
tx_tree.go 26.88% <33.33%> (-1.01%) ⬇️
tx.go 71.28% <77.77%> (-0.87%) ⬇️
db.go 61.96% <87.50%> (+1.13%) ⬆️
ttl_manager.go 92.00% <92.00%> (ø)
merge.go 73.09% <100.00%> (+0.15%) ⬆️
options.go 78.66% <100.00%> (+0.28%) ⬆️

Copy link
Member

@elliotchenzichang elliotchenzichang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

db.go Show resolved Hide resolved
db.go Outdated Show resolved Hide resolved
db.go Show resolved Hide resolved
merge.go Show resolved Hide resolved
options.go Show resolved Hide resolved
ttl_manager.go Outdated Show resolved Hide resolved
ttl_manager.go Outdated Show resolved Hide resolved
ttl_manager.go Outdated Show resolved Hide resolved
@elliotchenzichang
Copy link
Member

Please also help update the readme.md

Copy link
Member

@elliotchenzichang elliotchenzichang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliotchenzichang elliotchenzichang merged commit db9c9f9 into nutsdb:master Aug 16, 2023
6 checks passed
@bigboss2063 bigboss2063 deleted the ttl branch August 16, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants