-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add max write records control #459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipeline was broken. |
yes,I will find the problem and fixed
…---Original---
From: "Elliot ***@***.***>
Date: Mon, Sep 4, 2023 08:32 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [nutsdb/nutsdb] add max write records control (PR #459)
The pipeline was broken.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 72.99% 73.70% +0.71%
==========================================
Files 31 31
Lines 4184 4419 +235
==========================================
+ Hits 3054 3257 +203
- Misses 865 887 +22
- Partials 265 275 +10
|
bigboss2063
reviewed
Sep 6, 2023
bigboss2063
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues: #373
add max write records in memory control and return err at the threshold