Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max write records control #459

Merged
merged 11 commits into from
Sep 7, 2023
Merged

Conversation

damotiansheng
Copy link
Collaborator

issues: #373
add max write records in memory control and return err at the threshold

@elliotchenzichang
Copy link
Member

The pipeline was broken.

@damotiansheng
Copy link
Collaborator Author

damotiansheng commented Sep 4, 2023 via email

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #459 (e86709d) into master (8f8d8de) will increase coverage by 0.71%.
The diff coverage is 82.31%.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   72.99%   73.70%   +0.71%     
==========================================
  Files          31       31              
  Lines        4184     4419     +235     
==========================================
+ Hits         3054     3257     +203     
- Misses        865      887      +22     
- Partials      265      275      +10     
Files Changed Coverage Δ
set.go 82.11% <ø> (+0.98%) ⬆️
list.go 73.66% <72.22%> (+0.06%) ⬆️
db.go 67.44% <75.00%> (+0.54%) ⬆️
sorted_set.go 76.08% <80.00%> (+0.63%) ⬆️
tx.go 81.15% <84.12%> (+0.97%) ⬆️
utils.go 69.31% <89.28%> (+9.31%) ⬆️
options.go 79.74% <100.00%> (+1.08%) ⬆️

... and 1 file with indirect coverage changes

@bigboss2063 bigboss2063 self-requested a review September 6, 2023 07:22
tx.go Outdated Show resolved Hide resolved
tx.go Outdated Show resolved Hide resolved
tx.go Outdated Show resolved Hide resolved
Copy link
Member

@bigboss2063 bigboss2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigboss2063 bigboss2063 merged commit 51c9f27 into nutsdb:master Sep 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants